refactor(@angular/build): use new Angular SSR API #28283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
This was referenced Aug 27, 2024
alan-agius4
force-pushed
the
wireup-ssr
branch
2 times, most recently
from
f0582ff to
26e473c
Compare
alan-agius4
force-pushed
the
wireup-ssr
branch
5 times, most recently
from
27a2824 to
f9d95dc
Compare
alan-agius4
commented
Aug 29, 2024
| } = await loadEsmModuleFromMemory('./main.server.mjs'); | ||
| const angularServerApp = getOrCreateAngularServerApp(); | ||
| const response = await angularServerApp.render( | ||
| new Request(new URL(url, 'http://local-angular-prerender'), { |
There was a problem hiding this comment.
NB: http://local-angular-prerender is only temporary
alan-agius4
force-pushed
the
wireup-ssr
branch
3 times, most recently
from
07de060 to
4046058
Compare
alan-agius4
force-pushed
the
wireup-ssr
branch
from
4046058 to
24cf06a
Compare
alan-agius4
added
the
action: review
clydin
approved these changes
Sep 4, 2024
packages/angular/build/src/builders/application/execute-post-bundle.ts
Outdated
Show resolved
Hide resolved
| return response?.text(); | ||
| })() | ||
| .then((content) => { | ||
| if (typeof content !== 'string') { |
There was a problem hiding this comment.
Does undefined here mean there was an error or that the URL wasn't supported?
This commit introduces several key updates: - Updates Vite middleware to utilize the new SSR API. - Refactors prerendering, app-shell, and route extraction to align with the new rendering API. - Generates manifest files required by the new SSR API. **Note:** This is primarily a refactor; new features and improvements will be implemented in future updates.
…gularServerApp` This change is necessary to prevent NgModule-based rendering from failing with JIT in development mode.
alan-agius4
force-pushed
the
wireup-ssr
branch
from
24cf06a to
470a775
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several key updates:
Note: This is primarily a refactor; new features and improvements will be implemented in future updates.